fix(admin): prevent duplicated translated names in attribute resources#2444
Merged
alecritson merged 2 commits intolunarphp:1.xfrom Apr 13, 2026
Merged
Conversation
The names would be listed twice for both the attribute groups and the attribute names within a group. This fixes that. Includes testing for this fix too.
alecritson
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(admin): prevent duplicated translated names in attribute resources
Filament was receiving Lunar translatable name fields before they were
resolved to a single translated string. In Filament 4 that could be treated
as a multi-value state and rendered as duplicated text such as
"Details, Details".
Update TranslatedTextColumn to set the translated value as the column state
using Lunar's existing translate() / translateAttribute() helpers instead
of translating later during formatting. This keeps the current translation
system intact while ensuring Filament only renders one name.
This fixes duplicated names in:
Add regression coverage for both cases: